On Fri, 15 Dec 2023, rjingar wrote: > From: Rajvi Jingar <rajvi.jingar@xxxxxxxxxxxxxxx> > > Passing PMC_IDX_MAIN in pmc_core_pmc_add() adds only primary pmc to pmcdev. > Use pmc_idx instead to add all available pmcs. > > Fixes: a01486dc4bb1 ("platform/x86/intel/pmc: Cleanup SSRAM discovery") > Signed-off-by: Rajvi Jingar <rajvi.jingar@xxxxxxxxxxxxxxx> > --- > drivers/platform/x86/intel/pmc/core_ssram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/pmc/core_ssram.c b/drivers/platform/x86/intel/pmc/core_ssram.c > index 3501c7bd6b33..55e54207987c 100644 > --- a/drivers/platform/x86/intel/pmc/core_ssram.c > +++ b/drivers/platform/x86/intel/pmc/core_ssram.c > @@ -287,7 +287,7 @@ pmc_core_ssram_get_pmc(struct pmc_dev *pmcdev, int pmc_idx, u32 offset) > if (!map) > return -ENODEV; > > - return pmc_core_pmc_add(pmcdev, pwrm_base, map, PMC_IDX_MAIN); > + return pmc_core_pmc_add(pmcdev, pwrm_base, map, pmc_idx); Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> -- i.