Hi, On 12/4/23 15:11, Ilpo Järvinen wrote: > On Mon, 4 Dec 2023, Hans de Goede wrote: >> On 11/30/23 22:47, Srinivas Pandruvada wrote: >>> When a feature is read blocked, don't continue to read SST information >>> and register with SST core. >>> >>> When the feature is write blocked, continue to offer read interface for >>> SST parameters, but don't allow any operation to change state. A state >>> change results from SST level change, feature change or class of service >>> change. >>> >>> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> >>> --- >>> v2 >>> - Change read_blocked, write_blocked to bool >>> - Move the check for power_domain_info->write_blocked for SST-CP >>> to only write operations >> >> Thanks, patch looks good to me: >> >> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> Did you drop Ilpo's Reviewed-by from v1 on purpose >> because of the changes ? Or did you forget to add it ? > > No he didn't because this patch had an issue in v1 so I never gave my > rev-by for this patch. ;-) Ah, there are 2 patches with "Process read/write blocked feature status" as part of the subject, that confused me :) > But here it's now for v2: > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Thanks & Regards, Hans