Hi, On 11/30/23 22:47, Srinivas Pandruvada wrote: > If some TPMI features are disabled, don't create auxiliary devices. In > this way feature drivers will not load. > > While creating auxiliary devices, call tpmi_read_feature_status() to > check feature state and return if the feature is disabled without > creating a device. > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > v2 > - Add comment for returning -EOPNOTSUPP > > drivers/platform/x86/intel/tpmi.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/tpmi.c b/drivers/platform/x86/intel/tpmi.c > index c89aa4d14bea..868067ff966e 100644 > --- a/drivers/platform/x86/intel/tpmi.c > +++ b/drivers/platform/x86/intel/tpmi.c > @@ -604,9 +604,21 @@ static int tpmi_create_device(struct intel_tpmi_info *tpmi_info, > struct intel_vsec_device *vsec_dev = tpmi_info->vsec_dev; > char feature_id_name[TPMI_FEATURE_NAME_LEN]; > struct intel_vsec_device *feature_vsec_dev; > + struct tpmi_feature_state feature_state; > struct resource *res, *tmp; > const char *name; > - int i; > + int i, ret; > + > + ret = tpmi_read_feature_status(tpmi_info, pfs->pfs_header.tpmi_id, &feature_state); > + if (ret) > + return ret; > + > + /* > + * If not enabled, continue to look at other features in the PFS, so return -EOPNOTSUPP. > + * This will not cause failure of loading of this driver. > + */ > + if (!feature_state.enabled) > + return -EOPNOTSUPP; > > name = intel_tpmi_name(pfs->pfs_header.tpmi_id); > if (!name)
