On Tue, 28 Nov 2023, Srinivas Pandruvada wrote: > Modify the external interface tpmi_get_feature_status() to get read > and write blocked instead of locked and disabled. Since auxiliary device > is not created when disabled, no use of returning disabled state. Also > locked state is not useful as feature driver can't use locked state > in a meaningful way. > > Using read and write state, feature driver can decide which operations > to restrict for that feature. > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > --- > drivers/platform/x86/intel/tpmi.c | 8 ++++---- > include/linux/intel_tpmi.h | 5 ++--- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/platform/x86/intel/tpmi.c b/drivers/platform/x86/intel/tpmi.c > index 4edaa182db04..44773c210324 100644 > --- a/drivers/platform/x86/intel/tpmi.c > +++ b/drivers/platform/x86/intel/tpmi.c > @@ -351,8 +351,8 @@ static int tpmi_read_feature_status(struct intel_tpmi_info *tpmi_info, int featu > return ret; > } > > -int tpmi_get_feature_status(struct auxiliary_device *auxdev, int feature_id, > - int *locked, int *disabled) > +int tpmi_get_feature_status(struct auxiliary_device *auxdev, > + int feature_id, int *read_blocked, int *write_blocked) Noting down there's logical reversion of the parameters here as to me locked sound similar to write_blocked and disabled likewise to read_blocked but since there are no users for this function so far I suppose it's fine. Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> -- i.
