Hi, On 11/12/23 08:44, Christophe JAILLET wrote: > Use kasprintf() instead of hand writing it. > This saves the need of an intermediate buffer. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/dell/alienware-wmi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c > index a9477e5432e4..f5ee62ce1753 100644 > --- a/drivers/platform/x86/dell/alienware-wmi.c > +++ b/drivers/platform/x86/dell/alienware-wmi.c > @@ -429,7 +429,6 @@ static DEVICE_ATTR(lighting_control_state, 0644, show_control_state, > static int alienware_zone_init(struct platform_device *dev) > { > u8 zone; > - char buffer[10]; > char *name; > > if (interface == WMAX) { > @@ -466,8 +465,7 @@ static int alienware_zone_init(struct platform_device *dev) > return -ENOMEM; > > for (zone = 0; zone < quirks->num_zones; zone++) { > - sprintf(buffer, "zone%02hhX", zone); > - name = kstrdup(buffer, GFP_KERNEL); > + name = kasprintf(GFP_KERNEL, "zone%02hhX", zone); > if (name == NULL) > return 1; > sysfs_attr_init(&zone_dev_attrs[zone].attr);
