On Fri, 3 Nov 2023, Jules Irenge wrote:
> This commit fixes coccinelle warning in macro function
> IS_VRING_DROP() which complains conversion to bool not needed here.
>
> Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Not an end of the world but just in case you have it stored somewhere, my
email address was lacking the first letter in your post.
--
i.
> ---
> drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
> index ab7d7a1235b8..88472c024680 100644
> --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> @@ -91,7 +91,7 @@ struct mlxbf_tmfifo_vring {
> /* Check whether vring is in drop mode. */
> #define IS_VRING_DROP(_r) ({ \
> typeof(_r) (r) = (_r); \
> - (r->desc_head == &r->drop_desc ? true : false); })
> + r->desc_head == &r->drop_desc; })
>
> /* A stub length to drop maximum length packet. */
> #define VRING_DROP_DESC_MAX_LEN GENMASK(15, 0)
>
