On 11/13/23 15:19, Randy Dunlap wrote: > > > On 11/13/23 13:02, Henry Shi wrote: >> platform/x86: Add Silicom Platform Driver >> >> Add Silicom platform (silicom-platform) Linux driver for Swisscom >> Business Box (Swisscom BB) as well as Cordoba family products. >> >> This platform driver provides support for various functions via >> the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON) >> and device attributes. >> >> Signed-off-by: Henry Shi <henryshi2018@xxxxxxxxx> >> --- > > Hi, > > An x86_64 defconfig + this driver enabled gives me: > > > ld: vmlinux.o: in function `silicom_gpio_get': > silicom-platform.c:(.text+0xae6639): undefined reference to `gpiochip_get_data' > ld: vmlinux.o: in function `silicom_gpio_get_direction': > silicom-platform.c:(.text+0xae66a8): undefined reference to `gpiochip_get_data' > ld: vmlinux.o: in function `silicom_gpio_direction_input': > silicom-platform.c:(.text+0xae6888): undefined reference to `gpiochip_get_data' > ld: vmlinux.o: in function `silicom_gpio_set': > silicom-platform.c:(.text+0xae68d3): undefined reference to `gpiochip_get_data' > ld: silicom-platform.c:(.text+0xae68de): undefined reference to `gpiochip_get_data' > ld: vmlinux.o:silicom-platform.c:(.text+0xae69a1): more undefined references to `gpiochip_get_data' follow > ld: vmlinux.o: in function `silicom_platform_probe': > silicom-platform.c:(.init.text+0x656b7): undefined reference to `devm_gpiochip_add_data_with_key' so add depends on GPIOLIB for this driver. -- ~Randy
