Hi, On 10/19/23 04:20, 艾超 wrote: > Hi. > > >> Thanks this is much better. > >> Only remaining question I have is can the platform_profile >> setting be changed by a hotkey (directly by the hotkey, >> so upon pressing the hotkey the EC changes the platform_profile >> itself). > >> If the answer to this is yes, is there then any event which >> the driver could listen to and then use to notify userspace >> about the change by calling platform_profile_notify() upon >> receiving the event ? > >> Or maybe the event will be received by the discussed >> hotkeys driver, so that can call platform_profile_notify() >> instead. Note platform_profile_notify() does not require a >> platform_profile_handler pointer, so it could indeed be >> called from a separate driver if the events are received >> elsewhere. > >> Regards, > >> Hans > > There is no any event need to listen by this driver. If user > > pressing the hotkey, desktop applications receive > > hotkeys(Fn+Q) event, then APP get the currently power mode > and change it. The desktop applications modify brightness > > based on power mode. EC can't changes the power mode > > itself. OK, that is good to know. Thank you for answering my questions about this. I believe that once the few small remaining review remarks are addressed this should be ready for merging then. Regards, Hans
