Hi, On 10/16/23 16:47, Mark Brown wrote: > On Sat, Oct 14, 2023 at 10:53:14PM +0200, Hans de Goede wrote: > >> + .micd_force_micbias = 1, >> + .micd_configs = lenovo_yt3_wm5102_micd_config, >> + .num_micd_configs = ARRAY_SIZE(lenovo_yt3_wm5102_micd_config), >> + .micbias={ >> + [0]={ /*MICBIAS1*/ >> + .mV =2800 , >> + .ext_cap=1, > > The indentation of this section seems weird - .micbias is indented and > the lack of spaces around =s is odd. There's also an extra space before > the , consistently on the mV lines. Right this is a copy and paste fail on my side, I've fixed this up locally already, so this will be fixed in the next version. Regards, Hans