Hi, I added checkpatch people, please check what looks a false positive below. On Thu, 12 Oct 2023, David E. Box wrote: > On Thu, 2023-10-12 at 13:25 +0800, kernel test robot wrote: > > Hi David, > > > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on acce85a7dd28eac3858d44230f4c65985d0f271c] > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/David-E-Box/platform-x86-intel-vsec-Move-structures-to-header/20231012-104217 > > base: acce85a7dd28eac3858d44230f4c65985d0f271c > > patch link: > > https://lore.kernel.org/r/20231012023840.3845703-4-david.e.box%40linux.intel.com > > patch subject: [PATCH V3 03/16] platform/x86/intel/vsec: Use cleanup.h > > reproduce: > > (https://download.01.org/0day-ci/archive/20231012/202310121314.3Xpqom2w-lkp@in > > tel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version > > of > > the same patch/commit), kindly add following tags > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > Closes: > > > https://lore.kernel.org/oe-kbuild-all/202310121314.3Xpqom2w-lkp@xxxxxxxxx/ > > > > # many are suggestions rather than must-fix > > > > ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) > > #31: FILE: drivers/platform/x86/intel/vsec.c:159: > > + struct intel_vsec_device __free(kfree) *intel_vsec_dev = NULL; > > These looks like false positives. I agree. If I interpret the error message right checkpatch seems to think that's a multiplication which is not the case here. -- i.
