On Thu, 2023-10-12 at 18:01 +0300, Ilpo Järvinen wrote: > On Wed, 11 Oct 2023, David E. Box wrote: > > > Currently, if the PMC SSRAM initialization fails, no error is returned and > > the only indication is that a PMC device has not been created. Instead, > > allow an error to be returned and handled directly by the caller. > > You might have a good reason for it but why isn't the call into > pmc_core_pmc_add() changed in this patch to take the error value into > account? Good catch. The return value of pmc_core_pmc_add() is first used in the next patch but should be used here. David > > (I vaguely remember this was probably discussed in the context of some > earlier patch touching this area that it was about the other code dealing > with NULLs or something like that).
