On Fri, 6 Oct 2023, Nikita Kravets wrote:
> Fix the charge control address of CONF3 and remove an incorrect firmware
> version which turned out to be a BIOS firmware and not an EC firmware.
>
> Fixes: 392cacf2aa10 ("platform/x86: Add new msi-ec driver")
> Cc: Aakash Singh <mail@xxxxxxxxxxxxxxx>
> Cc: Jose Angel Pastrana <japp0005@xxxxxxxxxxxx>
> Signed-off-by: Nikita Kravets <teackot@xxxxxxxxx>
> ---
> drivers/platform/x86/msi-ec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-ec.c b/drivers/platform/x86/msi-ec.c
> index f26a3121092f..492eb383ee7a 100644
> --- a/drivers/platform/x86/msi-ec.c
> +++ b/drivers/platform/x86/msi-ec.c
> @@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = {
>
> static const char * const ALLOWED_FW_3[] __initconst = {
> "1592EMS1.111",
> - "E1592IMS.10C",
> NULL
> };
>
> static struct msi_ec_conf CONF3 __initdata = {
> .allowed_fw = ALLOWED_FW_3,
> .charge_control = {
> - .address = 0xef,
> + .address = 0xd7,
> .offset_start = 0x8a,
> .offset_end = 0x80,
> .range_min = 0x8a,
Thanks.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
--
i.
