Hi Ilpo, On 10/6/2023 3:57 PM, Ilpo Järvinen wrote: > On Thu, 5 Oct 2023, Hans de Goede wrote: >> On 10/5/23 12:15, Ilpo Järvinen wrote: >>> On Wed, 4 Oct 2023, Hans de Goede wrote: >>>> On 10/4/23 14:11, Shyam Sundar S K wrote: >>>>> Thank you for the detailed feedback. I will make these changes and see >>>>> if that helps - will need some time do tests and come back on this. >>>>> >>>>> Meanwhile, is it OK for you to take changes in v4 1/2 atleast? So that >>>>> I don't need to respin it again (assuming there are no remarks for 1/2). >>>> >>>> Note I have a new pdx86 co-maintainer Ilpo who is merging the patches >>>> leading up to the 6.7 merge window (Ilpo and I plan to take turns for this). >>>> >>>> IMHO it will be easier for Ilpo to merge the whole series in one >>>> go when it is ready. >>> >>> I can take single patches just as easily as the whole series as my tools >>> anyway explode the whole series into individual patches as an intermediate >>> step. >>> >>> I'll look into it tomorrow. There seemed to be one whitespace issue in the >>> debug print but I can deal with that myself while applying but other than >>> that, 1/2 seems fine to me. > > I've now applied 1/2 into my local review-ilpo branch. > This really helps, thank you. Thanks, Shyam