On Fri, Oct 06, 2023 at 05:34:19PM +0200, Hans de Goede wrote: > On 10/6/23 17:31, Andy Shevchenko wrote: ... ` > Thanks, patch looks good to me: > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Same issue as with other patch... ... > > + id = acpi_match_device(ebook_device_ids, device); Should be acpi_match_acpi_device(). > > + if (!id) { > > + dev_err(&device->dev, "Unsupported hid\n"); > > error = -ENODEV; > > goto err_free_input; > > } -- With Best Regards, Andy Shevchenko