On Thu, 5 Oct 2023, Jithu Joseph wrote: > Array BIST MSR addresses, bit definition and semantics are different for > Sierra Forest. Branch into a separate Array BIST flow on Sierra Forest > when user invokes Array Test. > > Signed-off-by: Jithu Joseph <jithu.joseph@xxxxxxxxx> > Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx> > Tested-by: Pengfei Xu <pengfei.xu@xxxxxxxxx> > --- > drivers/platform/x86/intel/ifs/ifs.h | 7 +++++ > drivers/platform/x86/intel/ifs/core.c | 15 +++++----- > drivers/platform/x86/intel/ifs/runtest.c | 37 +++++++++++++++++++++++- > 3 files changed, 51 insertions(+), 8 deletions(-) > > diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h > index f0dd849b3400..2dd5e3406dac 100644 > --- a/drivers/platform/x86/intel/ifs/ifs.h > +++ b/drivers/platform/x86/intel/ifs/ifs.h > @@ -137,6 +137,8 @@ > #define MSR_CHUNKS_AUTHENTICATION_STATUS 0x000002c5 > #define MSR_ACTIVATE_SCAN 0x000002c6 > #define MSR_SCAN_STATUS 0x000002c7 > +#define MSR_ARRAY_TRIGGER 0x000002d6 > +#define MSR_ARRAY_STATUS 0x000002d7 > #define MSR_SAF_CTRL 0x000004f0 > > #define SCAN_NOT_TESTED 0 > @@ -146,6 +148,9 @@ > #define IFS_TYPE_SAF 0 > #define IFS_TYPE_ARRAY_BIST 1 > > +#define ARRAY_GEN_0 0 > +#define ARRAY_GEN_1 1 Thank you for your contribution. I've applied this series to my local review-ilpo branch. I ended up renaming these defines ARRAY_GEN_* -> ARRAY_GEN* to make them more consistent. -- i.
