Hi Nikita, Ilpo, Nikita, great to see that you are back to contributing to the driver upstream. On 9/29/23 18:07, Ilpo Järvinen wrote: > > On Fri, 29 Sep 2023, Nikita Kravets wrote: > >> Fix the charge control address of CONF3 and remove an incorrect firmware >> version which turned out to be a BIOS firmware and not an EC firmware. > > Should there be a Fixes tag? > >> This patch also renames fn_super_swap to fn_win_swap for consistency >> with the downstream version of the driver. > > Please don't mix changes like this. > > Hans, what do you think about the rename in this patch? I agree with you that the config fixes and the rename should be 2 separate patches. > (To me "super" > sounds the normal terminology in Linux world so it feels a step > backwards.) win/super is used interchangeable in many places and only old Unix/X11 folks really know/expect the super name. So I'm fine with the rename. Also as Nikita mentions this keeps the code in sync with the out of tree driver, which currently has many more features then the mainline driver. The plan is to upstream those features one by one (or a few at a time). Given the situation with an out of tree driver + a mainline one for now keeping the per laptop model config in sync (which is the trickiest part to test) is a good idea IMHO. So ack from me for doing the rename. Regards, Hans
