On Mon, 25 Sep 2023, Joseph, Jithu wrote:
> On 9/25/2023 8:39 AM, Ilpo Järvinen wrote:
> > On Fri, 22 Sep 2023, Jithu Joseph wrote:
> >
>
> ...
>
> >>
> >> - activate.rsvd = 0;
> >> activate.delay = IFS_THREAD_WAIT;
> >> activate.sigmce = 0;
> >> - activate.start = 0;
> >> - activate.stop = ifsd->valid_chunks - 1;
> >> + to_start = 0;
> >> + to_stop = ifsd->valid_chunks - 1;
> >> +
> >> + if (ifsd->generation) {
> >> + activate.gen2.start = to_start;
> >> + activate.gen2.stop = to_stop;
> >> + } else {
> >> + activate.gen0.start = to_start;
> >> + activate.gen0.stop = to_stop;
> >> + }
> >
> > Is it okay to not do activate.gen0.rsvd = 0 anymore? If you know it is, it
> > would be nice to record that fact into the changelog so that it can be
> > found in the history.
>
> I did test on a gen0 to check if there is a problem due to this (and it seemed fine).
> I will make a note in changelog as you suggest
Actually, I realized activate is a variable in stack and those bits are
uninitilized without that assignment so don't remove it.
--
i.
