If a duplicate attribute is found using kset_find_obj(), a reference to that attribute is returned which needs to be disposed accordingly using kobject_put(). This issue likely first appeared inside the dell-wmi-sysman driver, see commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak"). However, it also seems that the bug was copied from this driver into the think-lmi and hp-bioscfg drivers. Maybe a more abstract fw_attr_class could prevent such issues in the future by abstracting away the kobject handling? Armin Wolf (2): platform/x86: think-lmi: Fix reference leak platform/x86: hp-bioscfg: Fix reference leak drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 14 ++++++++---- drivers/platform/x86/think-lmi.c | 24 ++++++++++++++++---- 2 files changed, 30 insertions(+), 8 deletions(-) -- 2.39.2