Appreciate the review
On 9/15/2023 9:22 AM, Ilpo Järvinen wrote:
> On Wed, 13 Sep 2023, Jithu Joseph wrote:
>
>> IFS generation number is reported via MSR_INTEGRITY_CAPS.
>
> Please use more characters per line, the limit is 72 characters.
>
Noted
...
>> +#define MSR_INTEGRITY_CAPS_SAF_GEN_REV_SHIFT 9
>> +#define MSR_INTEGRITY_CAPS_SAF_GEN_REV_MASK (0x3ull << MSR_INTEGRITY_CAPS_SAF_GEN_REV_SHIFT)
>
> GENMASK_ULL(), don't add _SHIFT at all as FIELD_GET/PREP() will handle
> it for you.
Thanks, Will change
...
>> struct ifs_work {
>> diff --git a/drivers/platform/x86/intel/ifs/core.c b/drivers/platform/x86/intel/ifs/core.c
>> index 306f886b52d2..88d84aad9334 100644
>> --- a/drivers/platform/x86/intel/ifs/core.c
>> +++ b/drivers/platform/x86/intel/ifs/core.c
>> @@ -94,6 +94,8 @@ static int __init ifs_init(void)
>> for (i = 0; i < IFS_NUMTESTS; i++) {
>> if (!(msrval & BIT(ifs_devices[i].test_caps->integrity_cap_bit)))
>> continue;
>> + ifs_devices[i].rw_data.generation = (msrval & MSR_INTEGRITY_CAPS_SAF_GEN_REV_MASK)
>> + >> MSR_INTEGRITY_CAPS_SAF_GEN_REV_SHIFT;
>
> FIELD_GET(), don't forget to make sure use have the include for it.
Will change
Jithu
