On Wed, 13 Sep 2023, Jithu Joseph wrote:
> Add an additional check to validate IFS image metadata field
> prior to loading the test image.
>
> If start_chunk is not a multiple of chunks_per_stride error out.
>
> Signed-off-by: Jithu Joseph <jithu.joseph@xxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> Tested-by: Pengfei Xu <pengfei.xu@xxxxxxxxx>
> ---
> drivers/platform/x86/intel/ifs/load.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
> index 778a3b89a24d..88630366a23c 100644
> --- a/drivers/platform/x86/intel/ifs/load.c
> +++ b/drivers/platform/x86/intel/ifs/load.c
> @@ -292,6 +292,13 @@ static int validate_ifs_metadata(struct device *dev)
> return ret;
> }
>
> + if (ifs_meta->chunks_per_stride &&
> + (ifs_meta->starting_chunk % ifs_meta->chunks_per_stride)) {
While this is not incorrect, it would make the code easier to understand
if you add != 0.
> + dev_warn(dev, "Starting chunk num %d not a multiple of chunks_per_stride %d\n",
> + ifs_meta->starting_chunk, ifs_meta->chunks_per_stride);
> + return ret;
> + }
> +
> return 0;
> }
>
>
--
i.
