Quoting Kuppuswamy Sathyanarayanan (2023-08-31 07:27:35) > > > Since you are not using the return value, I would not use time_left. I think the > following version is easy to read. But it is up to you. > > wait_for_completion_timeout(&scu->cmd_complete, IPC_TIMEOUT) > > status = ipc_read_status(scu); > > if (status & IPC_STATUS_BUSY) > return -ETIMEDOUT; > > if (status & IPC_STATUS_ERR) > return -EIO; > > return 0; > > With above fixed, you can add Thanks! That's a lot better.
