Hi Ilpo Jarvinen,
Thank you so much for your review comments!
On 8/21/2023 4:15 PM, Ilpo Järvinen wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
The coverletter has 0/3 but the patches came with /4?!?
This is by mistake. I will correct it in next version.
On Fri, 18 Aug 2023, Suma Hegde wrote:
From: Suma Hegde<suma.hegde@xxxxxxx>
The print message during platform init is little ambiguous
so change it to a more meaningful clear message.
Signed-off-by: Suma Hegde<suma.hegde@xxxxxxx>
Reviewed-by: Naveen Krishna Chatradhi<nchatrad@xxxxxxx>
---
drivers/platform/x86/amd/hsmp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c
index cab59750cde2..1f03a22a9d8a 100644
--- a/drivers/platform/x86/amd/hsmp.c
+++ b/drivers/platform/x86/amd/hsmp.c
@@ -537,10 +537,10 @@ static int __init hsmp_plt_init(void)
for (i = 0; i < num_sockets; i++) {
ret = hsmp_test(i, 0xDEADBEEF);
if (ret) {
- pr_err("HSMP is not supported on Fam:%x model:%x\n",
+ pr_err("HSMP test message failed on Fam:%x model:%x\n",
boot_cpu_data.x86, boot_cpu_data.x86_model);
- pr_err("Or Is HSMP disabled in BIOS ?\n");
- return -EOPNOTSUPP;
+ pr_err("Is HSMP disabled in BIOS ?\n");
+ return ret;
Your changelog only talks about changing print, and yet you also change
return statement. Please explain things properly in the changelog (or
perhaps even make a separate patch out of the return change if it's
independent change you planned to make).
I missed mentioning about changed return statement in , will correct
this too in the next version.
--
i.
