Hi Hans, On 8/21/2023 11:22 PM, Hans de Goede wrote: > Hi Again, > > On 8/21/23 14:57, Hans de Goede wrote: >> Hi Shyam, >> >> On 8/11/23 13:21, Shyam Sundar S K wrote: >>> This patch series includes: >>> >>> - Move PMC driver to separate directory >> >> This one seems to rely on the state of the amd-pmc code in pdx86/fixes >> which is also the state in Linus' master but not the state in pdx86/for-next >> which is based on 6.5-rc1 where as e.g. : >> >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=fixes&id=e8ef8dd28c4c4b86cd3010ff42c79582f766862e >> >> Which adds the pmc-quirks.c file was added later in the fixes branch. >> >> So it is best to do this moving into a separate dir directly >> after 6.6-rc1 is out, at which point fixes and for-next will have >> both been merged. > > So I have just back-merged pdx86/fixes into review-hans (future pdx86/for-next) > because some pending mellanox changes need this to avoid conflicts. > > As such I think I can pick this patch (the patch moving things into its > own subdir) now. > > I think it might be a good idea to merge this patch for the upcoming > 6.6 window so that we have the moving of files behind us. > > Shyam, shall I merge 1/4 into review-hans / for 6.6-rc1 now ? Yes please. I will drop 2/4 as per Mario's remark. Once you have 1/4 into review-hans, I will rebase my changes on top of it and send 3/4, 4/4 as v2. Will that work for you? Thanks, Shyam > > Regards, > > Hans > > > > >> >>> - Read SMU version at the time of probe to avoid duplication of code >> >> Please address the comments made on this patch (or drop it). >> >> I assume the rest relies on this patch, so I'm going to drop this >> entire series from my queue now. >> >> Regards, >> >> Hans >> >> >> >>> - Add a Firmware command that can force flush the Spill to DRAM contents. >>> - override the STB dump size with a custom one using a module_param >>> >>> >>> Shyam Sundar S K (4): >>> platform/x86/amd/pmc: Move PMC driver to separate directory >>> platform/x86/amd/pmc: Read SMU version at the time of probe >>> platform/x86/amd/pmc: Add PMFW command id to support S2D force flush >>> platform/x86/amd/pmc: Add dump_custom_stb module parameter >>> >>> MAINTAINERS | 2 +- >>> drivers/platform/x86/amd/Kconfig | 16 +--- >>> drivers/platform/x86/amd/Makefile | 3 +- >>> drivers/platform/x86/amd/pmc/Kconfig | 19 +++++ >>> drivers/platform/x86/amd/pmc/Makefile | 8 ++ >>> .../platform/x86/amd/{ => pmc}/pmc-quirks.c | 0 >>> drivers/platform/x86/amd/{ => pmc}/pmc.c | 80 ++++++++----------- >>> drivers/platform/x86/amd/{ => pmc}/pmc.h | 1 + >>> 8 files changed, 66 insertions(+), 63 deletions(-) >>> create mode 100644 drivers/platform/x86/amd/pmc/Kconfig >>> create mode 100644 drivers/platform/x86/amd/pmc/Makefile >>> rename drivers/platform/x86/amd/{ => pmc}/pmc-quirks.c (100%) >>> rename drivers/platform/x86/amd/{ => pmc}/pmc.c (96%) >>> rename drivers/platform/x86/amd/{ => pmc}/pmc.h (98%) >>> >
