Re: [PATCH platform-next 07/16] platform: mellanox: mlx-platform: Modify power off callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 14 Aug 2023, Vadim Pasternak wrote:

> Extend platform power off callback with kernel_halt() call.

That much is obvious from the code change itself but please amend this 
changelog with the answer to question "Why?" you're making this change.

-- 
 i.

> Signed-off-by: Vadim Pasternak <vadimp@xxxxxxxxxx>
> Reviewed-by: Michael Shych <michaelsh@xxxxxxxxxx>
> ---
>  drivers/platform/x86/mlx-platform.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
> index dce35934cc37..a505f619f337 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -5539,6 +5539,7 @@ static void mlxplat_poweroff(void)
>  	struct mlxplat_priv *priv = platform_get_drvdata(mlxplat_dev);
>  
>  	regmap_write(priv->regmap, MLXPLAT_CPLD_LPC_REG_GP1_OFFSET, MLXPLAT_CPLD_HALT_MASK);
> +	kernel_halt();
>  }
>  
>  static int __init mlxplat_dmi_default_matched(const struct dmi_system_id *dmi)
> 




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux