Hi, On 8/13/23 13:08, coolrrsh@xxxxxxxxx wrote: > From: Rajeshwar R Shinde <coolrrsh@xxxxxxxxx> > > The variable 'mode' is declared as unsigned int in local function. > The return value of function amd_pmf_get_pprof_modes(dev) is int and > it is stored in the 'mode' variable. Also the value of 'mode' variable > is compared with 0 which is signed int by default. Thus redeclaring the > variable to signed int. > > This fixes warning such as: > drivers/platform/x86/amd/pmf/sps.c:128:5-9: > WARNING: Unsigned expression compared with zero: mode < 0 > > Signed-off-by: Rajeshwar R Shinde <coolrrsh@xxxxxxxxx> Thank you your patch. This has already been fixed by a patch which is pending in the pdx86/fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=fixes&id=785c00993dc4c4bb2f7b0f3a3f29c03a6f7aab2e https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Regards, Hans
