I will submit a new patch replacing 'value_len' for 'size' in line 267 as indicated. 'value_len' is utilized earlier in the code so we cannot remove it completely from the function. On Tue, Aug 1, 2023 at 8:35 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > These are fine. We still need to do something like this. Also we could > just get rid of value_len completely. Nothing uses it. > > diff --git a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c > index cffc1c9ba3e77..6ba0e49e787ec 100644 > --- a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c > +++ b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c > @@ -264,7 +264,7 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord > * Ordered list data is stored in hex and comma separated format > * Convert the data and split it to show each element > */ > - ret = hp_convert_hexstr_to_str(str_value, value_len, &tmpstr, &tmp_len); > + ret = hp_convert_hexstr_to_str(str_value, size, &tmpstr, &tmp_len); > if (ret) > goto exit_list; >
