On Thu, Jul 27, 2023 at 10:54:26PM +0000, Barnabás Pőcze wrote: > 2023. július 26., szerda 10:45 keltezéssel, Hans de Goede <hdegoede@xxxxxxxxxx> írta: > > On 7/15/23 23:24, Barnabás Pőcze wrote: ... > > I think that having an additional check like the one which you > > propose has some value too, even if it is just to cover drivers > > which for some reason don't use `MODULE_DEVICE_TABLE()`, but IMHO > > the most important check to have is a check in file2alias.c . > > Okay... any tips on how to avoid copying `uuid_is_valid()`? I think I already told the rough design: we need to split uuid.c to three files: libuuid.h, libuuid.c uuid.c and libuuid.c should be built twice: once for uuid.c and once for file2alias.c. libuuid.h should contain the definitions file2alias.c is using. Something like that. > Another idea I had was that maybe `struct wmi_device_id::guid_string` needs to be > changed to be `guid_t` and then `GUID_INIT()` or something similar could be used > to initialize it. That way it is impossible to mess up the format. The only downside > I can see is that guid is no longer "grep-able". Strictly speaking you may not do that because it's a (semi-)ABI. -- With Best Regards, Andy Shevchenko
