Hi, On 7/14/23 19:49, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/chrome/cros_ec.c | 1 + > drivers/platform/mellanox/mlxreg-hotplug.c | 1 - > drivers/platform/mellanox/mlxreg-io.c | 1 - > 3 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c > index 8b7949220382..5d36fbc75e1b 100644 > --- a/drivers/platform/chrome/cros_ec.c > +++ b/drivers/platform/chrome/cros_ec.c > @@ -12,6 +12,7 @@ > #include <linux/interrupt.h> > #include <linux/module.h> > #include <linux/of_platform.h> > +#include <linux/platform_device.h> > #include <linux/platform_data/cros_ec_commands.h> > #include <linux/platform_data/cros_ec_proto.h> > #include <linux/slab.h> > diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c > index b7dcc64cd238..6ddfea0d4c5b 100644 > --- a/drivers/platform/mellanox/mlxreg-hotplug.c > +++ b/drivers/platform/mellanox/mlxreg-hotplug.c > @@ -12,7 +12,6 @@ > #include <linux/i2c.h> > #include <linux/interrupt.h> > #include <linux/module.h> > -#include <linux/of_device.h> > #include <linux/platform_data/mlxreg.h> > #include <linux/platform_device.h> > #include <linux/spinlock.h> > diff --git a/drivers/platform/mellanox/mlxreg-io.c b/drivers/platform/mellanox/mlxreg-io.c > index ddc08abf398c..83ba037408cd 100644 > --- a/drivers/platform/mellanox/mlxreg-io.c > +++ b/drivers/platform/mellanox/mlxreg-io.c > @@ -11,7 +11,6 @@ > #include <linux/hwmon.h> > #include <linux/hwmon-sysfs.h> > #include <linux/module.h> > -#include <linux/of_device.h> > #include <linux/platform_data/mlxreg.h> > #include <linux/platform_device.h> > #include <linux/regmap.h>
