On Wed, Jul 19, 2023 at 05:35:15PM +0200, Henning Schild wrote: > change since v1: > - switch LED/wdt Kconfig to "default y" > - remove guard which could hide whole siemens submenu, and default m > > This series does two things. It builds up a Kconfig inheritance chain > for all platform device drivers, namely Watchdog and LED. And then it > puts all Siemens Simatic IPC drivers in the platform/x86/ directory in > a subdirectory called "siemens". > > That is so that users have to flip less config switches, and to ease > maintenance. All three good enough, although I prefer the ordering that 'tristate' followed by 'default' without interleaved 'depends on'. I leave it to Hans. Other that that, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko