Re: [PATCH] efi: x86: prefer 'unsigned int' to bare use of 'unsigned'

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Sun, Jul 9, 2023 at 5:20 AM <xuanzhenggang001@xxxxxxxxxx> wrote:
>
> This patch fixes the following checkpatch warning:
> arch/x86/platform/efi/efi_64.c:109: WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'
> arch/x86/platform/efi/efi_64.c:177: WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'
> arch/x86/platform/efi/efi_64.c:182: WARNING: Prefer 'unsigned int' to
> bare use of 'unsigned'

> -int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned
> num_pages)
> +int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned int
> num_pages)

Nice, but you shouldn't just blindly do some mechanic "fixes". Now
your patch makes differences between the function prototype and its
implementation.

-- 
With Best Regards,
Andy Shevchenko