Hi, Three years ago I sent v3 of this series. There was never an anwser from Dmitry - no comment at all. Maybe after three years this can go in? It makes the code nicely smaller. Changes since v3: 1. Rebase 2. Drop gpio-keys patch as it depends on GPIO helpers and I am too bored to rebase it. v3: https://lore.kernel.org/all/20200827185829.30096-1-krzk@xxxxxxxxxx/ Changes since v2: 1. Add review tags, 2. Fixes after review (see individual patches). 3. Two new patches - 26 and 27. Best regards, Krzysztof Krzysztof Kozlowski (24): Input: gpio_keys_polled - Simplify with dev_err_probe() Input: gpio-vibra - Simplify with dev_err_probe() Input: pwm-vibra - Simplify with dev_err_probe() Input: rotary_encoder - Simplify with dev_err_probe() Input: elan_i2c - Simplify with dev_err_probe() Input: bu21013_ts - Simplify with dev_err_probe() Input: bu21029_ts - Simplify with dev_err_probe() Input: chipone_icn8318 - Simplify with dev_err_probe() Input: cy8ctma140 - Simplify with dev_err_probe() Input: edf-ft5x06 - Simplify with dev_err_probe() Input: ektf2127 - Simplify with dev_err_probe() Input: elants_i2c - Simplify with dev_err_probe() Input: goodix - Simplify with dev_err_probe() Input: melfas_mip4 - Simplify with dev_err_probe() Input: pixcir_i2c_ts - Simplify with dev_err_probe() Input: raydium_i2c_ts - Simplify with dev_err_probe() Input: resistive-adc-touch - Simplify with dev_err_probe() Input: silead - Simplify with dev_err_probe() Input: sis_i2c - Simplify with dev_err_probe() Input: surface3_spi - Simplify with dev_err_probe() Input: sx8643 - Simplify with dev_err_probe() Input: bcm-keypad - Simplify with dev_err_probe() Input: bu21013_ts - Use local 'client->dev' variable in probe() Input: bu21029_ts - Use local 'client->dev' variable in probe() drivers/input/keyboard/bcm-keypad.c | 14 ++-- drivers/input/keyboard/gpio_keys_polled.c | 8 +-- drivers/input/misc/gpio-vibra.c | 20 ++---- drivers/input/misc/pwm-beeper.c | 19 ++--- drivers/input/misc/pwm-vibra.c | 30 +++----- drivers/input/misc/rotary_encoder.c | 8 +-- drivers/input/mouse/elan_i2c_core.c | 9 +-- drivers/input/touchscreen/bu21013_ts.c | 72 ++++++++----------- drivers/input/touchscreen/bu21029_ts.c | 51 +++++-------- drivers/input/touchscreen/chipone_icn8318.c | 8 +-- drivers/input/touchscreen/cy8ctma140.c | 8 +-- drivers/input/touchscreen/edt-ft5x06.c | 10 +-- drivers/input/touchscreen/ektf2127.c | 8 +-- drivers/input/touchscreen/elants_i2c.c | 22 ++---- drivers/input/touchscreen/goodix.c | 40 +++-------- drivers/input/touchscreen/melfas_mip4.c | 9 +-- drivers/input/touchscreen/pixcir_i2c_ts.c | 38 ++++------ drivers/input/touchscreen/raydium_i2c_ts.c | 30 +++----- .../input/touchscreen/resistive-adc-touch.c | 8 +-- drivers/input/touchscreen/silead.c | 8 +-- drivers/input/touchscreen/sis_i2c.c | 20 ++---- drivers/input/touchscreen/surface3_spi.c | 13 +--- drivers/input/touchscreen/sx8654.c | 10 +-- 23 files changed, 146 insertions(+), 317 deletions(-) -- 2.34.1