Am 21.06.23 um 23:29 schrieb Barnabás Pőcze:
Hi
2023. június 21., szerda 23:20 keltezéssel, Armin Wolf <W_Armin@xxxxxx> írta:
[...]
@@ -895,11 +901,7 @@ static int wmi_dev_match(struct device *dev, struct device_driver *driver)
return 0;
while (*id->guid_string) {
- guid_t driver_guid;
-
- if (WARN_ON(guid_parse(id->guid_string, &driver_guid)))
Hi,
just an idea: how about printing an error/debug message in case of an malformed GUID?
This could be useful when searching for typos in GUIDs used by WMI drivers.
[...]
Wouldn't it be better to change `__wmi_driver_register()` to check that?
Regards,
Barnabás Pőcze
Good point, i guess we can just forget this idea. The original motivation for it was the WARN_ON()
inside wmi_dev_match(), but your right that this is the wrong place to check the GUID formating.
Armin Wolf
