Hi Jorge, On 2023-06-08 11:33:06-0500, Jorge Lopez wrote: <snip> > Signed-off-by: Jorge Lopez <jorge.lopez2@xxxxxx> <snip> > > .../testing/sysfs-class-firmware-attributes | 101 +- > MAINTAINERS | 6 + > drivers/platform/x86/hp/Kconfig | 16 + > drivers/platform/x86/hp/Makefile | 1 + > drivers/platform/x86/hp/hp-bioscfg/Makefile | 11 + > .../x86/hp/hp-bioscfg/biosattr-interface.c | 312 +++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 1055 +++++++++++++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 487 ++++++++ > .../x86/hp/hp-bioscfg/enum-attributes.c | 447 +++++++ > .../x86/hp/hp-bioscfg/int-attributes.c | 409 +++++++ > .../x86/hp/hp-bioscfg/order-list-attributes.c | 436 +++++++ > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 543 +++++++++ > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 386 ++++++ > .../x86/hp/hp-bioscfg/string-attributes.c | 390 ++++++ > .../x86/hp/hp-bioscfg/surestart-attributes.c | 132 +++ > 15 files changed, 4730 insertions(+), 2 deletions(-) > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c That looks much better now! Thanks for all the resubmissions. For the full series: Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> Thomas