Hi, On 6/6/23 17:18, Mark Pearson wrote: > Fix issues identified in dytc_profile_refresh identified by lkp-tests. > drivers/platform/x86/thinkpad_acpi.c:10538 > dytc_profile_refresh() error: uninitialized symbol 'funcmode'. > drivers/platform/x86/thinkpad_acpi.c:10531 > dytc_profile_refresh() error: uninitialized symbol 'output'. > drivers/platform/x86/thinkpad_acpi.c:10537 > dytc_profile_refresh() error: uninitialized symbol 'output'. > > These issues should not lead to real problems in the field as the refresh > function should only be called if MMC or PSC mode enabled. But good to fix. > > Thanks to Dan Carpenter and the lkp-tests project for flagging these. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Closes: https://lore.kernel.org/r/202306011202.1hbgLRD4-lkp@xxxxxxxxx/ > Fixes: 1bc5d819f0b9 ("platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms") > Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/thinkpad_acpi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index b3808ad77278..4b89f42de723 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -10524,7 +10524,7 @@ static int dytc_profile_set(struct platform_profile_handler *pprof, > static void dytc_profile_refresh(void) > { > enum platform_profile_option profile; > - int output, err = 0; > + int output = 0, err = 0; > int perfmode, funcmode; > > mutex_lock(&dytc_mutex); > @@ -10538,6 +10538,8 @@ static void dytc_profile_refresh(void) > err = dytc_command(DYTC_CMD_GET, &output); > /* Check if we are PSC mode, or have AMT enabled */ > funcmode = (output >> DYTC_GET_FUNCTION_BIT) & 0xF; > + } else { /* Unknown profile mode */ > + err = -ENODEV; > } > mutex_unlock(&dytc_mutex); > if (err)
