Re: [PATCH] platform/x86/amd/pmf: Fix compiler warnings in static slider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 16 May 2023, Shyam Sundar S K wrote:

> This patch fixes warnings with -Wmissing-prototypes:
> 
> warning: no previous prototype for 'source_as_str' [-Wmissing-prototypes]
> warning: no previous prototype for 'slider_as_str' [-Wmissing-prototypes]
> 
> Fixes: a82ebb3d800d ("platform/x86/amd/pmf: Add PMF acpi debug support")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202305160220.REQc5T2y-lkp@xxxxxxxxx/
> Suggested-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
> ---
>  drivers/platform/x86/amd/pmf/sps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/sps.c b/drivers/platform/x86/amd/pmf/sps.c
> index 0a4d0549ea03..445ff053b4df 100644
> --- a/drivers/platform/x86/amd/pmf/sps.c
> +++ b/drivers/platform/x86/amd/pmf/sps.c
> @@ -13,7 +13,7 @@
>  static struct amd_pmf_static_slider_granular config_store;
>  
>  #ifdef CONFIG_AMD_PMF_DEBUG
> -const char *slider_as_str(unsigned int state)
> +static const char *slider_as_str(unsigned int state)
>  {
>  	switch (state) {
>  	case POWER_MODE_PERFORMANCE:
> @@ -27,7 +27,7 @@ const char *slider_as_str(unsigned int state)
>  	}
>  }
>  
> -const char *source_as_str(unsigned int state)
> +static const char *source_as_str(unsigned int state)
>  {
>  	switch (state) {
>  	case POWER_SOURCE_AC:
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

-- 
 i.

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux