Re: [PATCH v2 18/19] platform/x86: lenovo-yogabook: Add keyboard backlight control to platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 5, 2023 at 12:21 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> On Fri, May 05, 2023 at 12:07:02PM +0300, Andy Shevchenko wrote:
> > On Thu, May 4, 2023 at 7:53 PM Uwe Kleine-König
> > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > > On Sun, Apr 30, 2023 at 06:58:06PM +0200, Hans de Goede wrote:

...

> > > I don't know much about x86, but I think the table belongs to where this
> > > "80862289:00" device is created.
> >
> > Just for your information, it's in drivers/acpi/acpi_lpss.c.
>
> Compared to drivers/platform/x86/lenovo-yogabook-wmi.c this file is
> never compiled as a module and so patch #1 would become unnecessary.
>
> That file also already has a pwm_lookup table.

TBH, Hans knows nowadays much better what those drivers do and why the
split was done this way. If he thinks that it's needed, I will trust
his word.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux