On Sat, Apr 29, 2023 at 9:16 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On the Android yb1-x90f/l models there is not ACPI method to control > the keyboard backlight brightness. Instead the second PWM controller > is exposed directly to the OS there. > > Add support for controlling keyboard backlight brightness on the Android > model by using the PWM subsystem to directly control the PWM. ... > +#define YB_KBD_BL_PWM_PERIOD 13333 Defined... > +static struct pwm_lookup yogabook_pdev_pwm_lookup[] = { > + PWM_LOOKUP_WITH_MODULE("80862289:00", 0, YB_PDEV_NAME, > + "kbd_bl_pwm", 13333, PWM_POLARITY_NORMAL, ...but not used? > + "pwm-lpss-platform"), > +}; ... > + if (IS_ERR(data->kbd_bl_pwm)) { > + r = PTR_ERR(data->kbd_bl_pwm); > + dev_err_probe(dev, r, "Getting keyboard backlight PWM\n"); r = dev_err_probe(); > + goto error_put_devs; > + } -- With Best Regards, Andy Shevchenko