Hi Mark and Hans, please see my reply inline. On Tuesday, April 18th, 2023 at 15:23, Hans de Goede wrote: > On 4/18/23 15:16, Mark Pearson wrote: > > > > > Sorry for the slow reply on this one. > > > > I checked with the FW team and they confirmed on the x380 Yoga that the implementation is unique and not using the ECRD/WCWR ACPI methods. They didn't say why...but it's not expected to be something done again. Thank you and the FW team for the quick reply! As a first time kernel hacker, I find my experience top-notch :) > > I had missed the question about fan control so didn't ask about that. Is there a reason you need to change the fans? It's generally not recommended as it can violate temperature specs and leads to all sorts of issues. My end goal is to hopefully get a bit more performance out of my machine by making the fan kick in earlier using Thinkfan. I have been doing a lot of compile-heavy development lately on my X380 Yoga, and I noticed that the CPU will throttle down to around 1.4 GHz at full load. This might just be normal for such a small ultrabook, but I want to get the most out of it, as I'm likely going to be stuck with this laptop for my first year of CS studies. Additionally, I remember the fans being louder at full load back when I used Windows. With this patch, I can see that the highest it gets is 4800 RPM. My memory might just be wrong though, and if so, I apologize for wasting your time. I have set "Adaptive Thermal Management" to "Maximize Performance" in the BIOS, but I don't see a significant improvement. > > I don't know if the fact this is a one off makes this a better candidate as a quirk? To reduce the risk of breaking something on other platforms? But the code changes looked sensible to me. > > > > I'll aim to do some builds with it in and test it on a few platforms - but I'm travelling next week so this week (and almost certainly the week after) are a bit hectic. Thank you again. In no way is this patch urgent, so feel free to take your time. > > > I just remembered that making thinkpad_acpi fan-control > actually requires passing a module-parameter, because as > said generally speaking leaving the fan on auto mode is best. > > I wonder if that parameter was set when testing on > the X380 ? I guess it was set since the actual > register was inspected and the changes were visible > there, right ? This is correct, I did set fan_control=1 for my testing. Writes to /proc/acpi/ibm/fan are rejected otherwise. > > Regards, > > Hans Regards, Daniel
