Hi Julian, +Cc Andy, Mika, On 4/16/23 17:49, Julian Winkler wrote: > This id was removed in b47018a778c1a18cbc98b4a11936dec4f8c4bb7b, saying it > is only used on Moorestown, but apparently the same id is also used on > Medfield. > > Tested on the Medfield based Motorola RAZR i smartphone. > > Signed-off-by: Julian Winkler <julian.winkler1@xxxxxx> Hmm, so this is a former SFI platform, from your: https://lore.kernel.org/all/20230223060107.23029-1-julian.winkler1@xxxxxx/ patch I guess the plan is to use some custom bootloader and then use x86 with devicetree support to replace SFI ? Do you already have this working ? Sorry for all the questions for what is just a simple PCI-id addition. I guess I'm worried this is just the tip of the iceberg for getting medfield support back into the kernel and I'm a bit worried about how much maintenance work this will cause. E.g. also see commit e1da811218d2dc ("drm/gma500: Remove Medfield support") which I guess you will want to see reverted too ? That is an example of a lot more code to bring back then just a single PCI-id addition. Don't get me wrong I'm all for supporting older hw if there are users who are interested in actively maintaining support for it. I just want to get a feel of the amount of work this is going to involve. Andy, Mika, any remarks ? Regards, Hans > --- > drivers/platform/x86/intel_scu_pcidrv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c > index 80abc708e4f2..d904fad499aa 100644 > --- a/drivers/platform/x86/intel_scu_pcidrv.c > +++ b/drivers/platform/x86/intel_scu_pcidrv.c > @@ -34,6 +34,7 @@ static int intel_scu_pci_probe(struct pci_dev *pdev, > > static const struct pci_device_id pci_ids[] = { > { PCI_VDEVICE(INTEL, 0x080e) }, > + { PCI_VDEVICE(INTEL, 0x082a) }, > { PCI_VDEVICE(INTEL, 0x08ea) }, > { PCI_VDEVICE(INTEL, 0x0a94) }, > { PCI_VDEVICE(INTEL, 0x11a0) },
