Hi, On 4/13/23 12:17, Ilpo Järvinen wrote: > On Wed, 12 Apr 2023, David E. Box wrote: > >> On some platforms, it may take up to 400ms for the ready bit to be set in a >> successful mailbox transaction. Set the timeout to 500ms to cover the worst >> case. >> >> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> >> --- >> drivers/platform/x86/intel/sdsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c >> index 9e0ea2cdd704..556e7c6dbb05 100644 >> --- a/drivers/platform/x86/intel/sdsi.c >> +++ b/drivers/platform/x86/intel/sdsi.c >> @@ -49,7 +49,7 @@ >> #define SDSI_MBOX_CMD_SUCCESS 0x40 >> #define SDSI_MBOX_CMD_TIMEOUT 0x80 >> >> -#define MBOX_TIMEOUT_US 2000 >> +#define MBOX_TIMEOUT_US 500000 >> #define MBOX_TIMEOUT_ACQUIRE_US 1000 >> #define MBOX_POLLING_PERIOD_US 100 >> #define MBOX_ACQUIRE_NUM_RETRIES 5 > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Thank you both for the patch + review, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans
