Hi Jorge, On 2023-04-12 14:37:45-0500, Jorge Lopez wrote: > On Sun, Apr 2, 2023 at 11:28 AM Thomas Weißschuh <thomas@xxxxxxxx> wrote: > > Instead of passing around integer ids, that all the callees are using to > > look up some global data, it would be nicer to pass a pointer to the > > concrete instance struct to work on. > > > > validate_string_input is part of the defined function > ATTRIBUTE_PROPERTY_STORE in bioscfg.h (line 457). > > > This makes the code simpler and removes reference to global state all > > over the place. > > > Changing the values from int to pointer will add unnecessary overhead > since the instance ID is searched only once earlier in the process. Is this overhead measurable? If it can't be measured and/or does not make a difference, code clarity should always trump performance. On the other hand if you think the current way is clearer just keep it as is. Thomas
