Hi, On 4/10/23 22:26, Limonciello, Mario wrote: > [Public] > >> Now that the pmc code has switched to DEFINE_SIMPLE_DEV_PM_OPS() >> the __maybe_unused is no longer necessary, drop it. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> drivers/platform/x86/amd/pmc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/amd/pmc.c >> b/drivers/platform/x86/amd/pmc.c >> index 2761e9b76e95..2e2b99b93df7 100644 >> --- a/drivers/platform/x86/amd/pmc.c >> +++ b/drivers/platform/x86/amd/pmc.c >> @@ -840,7 +840,7 @@ static struct acpi_s2idle_dev_ops >> amd_pmc_s2idle_dev_ops = { >> .restore = amd_pmc_s2idle_restore, >> }; >> >> -static int __maybe_unused amd_pmc_suspend_handler(struct device >> *dev) >> +static int amd_pmc_suspend_handler(struct device *dev) >> { >> struct amd_pmc_dev *pdev = dev_get_drvdata(dev); >> >> -- >> 2.39.1 > > Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx> Thanks. I've added this to my review-hans (soon to be for-next) branch now. Regards, Hans