Hi Shyam,
On 4/9/23 20:53, Shyam Sundar S K wrote:
> This patch series includes:
>
> 1. Fixes to Picasso from Mario
> 2. Change the SMN pair index for driver probing & STB init
> 3. New command ID for getting DRAM size from PMFW.
> 4. Change in smu metrics table data structure.
>
> Mario Limonciello (4):
> platform/x86/amd: pmc: Don't try to read SMU version on Picasso
> platform/x86/amd: pmc: Hide SMU version and program attributes for
> Picasso
> platform/x86/amd: pmc: Don't dump data after resume from s0i3 on
> picasso
> platform/x86/amd: pmc: Move idlemask check into
> `amd_pmc_idlemask_read`
>
> Shyam Sundar S K (4):
> platform/x86/amd: pmc: Utilize SMN index 0 for driver probe
> platform/x86/amd: pmc: Move out of BIOS SMN pair for STB init
> platform/x86/amd: pmc: Get STB DRAM size from PMFW
> platform/x86/amd: pmc: update metrics table info for Pink Sardine
>
> drivers/platform/x86/amd/Kconfig | 2 +-
> drivers/platform/x86/amd/pmc.c | 240 ++++++++++++++++++-------------
> 2 files changed, 145 insertions(+), 97 deletions(-)
Thanks for the patches I have merged patches 1-6 into my
review-hans (soon to be for-next) branch now.
I agree with Mario that the firmware version check in 7/8
should look like this:
"""
Is this only for YC and not for PS?
The version check I think you should make it clear it's only intended for this program.
switch(dev->cpu_id) {
case AMD_CPU_ID_YC:
if (version_check)
goto err_dram_size;
break;
default:
goto err_dram_size;
}
"""
Since we have seen in earlier patches in this series that we will otherwise need to make this a per CPU-id check later we might just as well do it now.
Please send a new version of patches 7 + 8 based on top of my review-hans branch.
Regards,
Hans
