Hi Mark, On 4/3/23 16:41, Mark Pearson wrote: > Hi Hans > > On Mon, Apr 3, 2023, at 6:03 AM, Hans de Goede wrote: >> Hi, >> >> On 4/1/23 01:24, Benjamin Asbach wrote: >>>> Lenovo laptops that contain NVME SSDs across a variety of generations have >>>> trouble resuming from suspend to idle when the IOMMU translation layer is >>>> active for the NVME storage device. >>>> >>>> This generally manifests as a large resume delay or page faults. These >>>> delays and page faults occur as a result of a Lenovo BIOS specific SMI >>>> that runs during the D3->D0 transition on NVME devices. >>> >>> Link: https://lore.kernel.org/all/20220503183420.348-1-mario.limonciello@xxxxxxx/ >>> >>> As Lenovo distributes T14s Gen1 laptops with different product names >>> a missing one is added by this patch. >>> >>> Note: Based on lenovo support page there might be some more variants which >>> are not represented in s2idle quirk list. >> >> Can you provide some more in info on this? Then Mark can maybe check >> if we need to add more models ? >> >> Mark, generally speaking it may help to do a DMI_EXACT_MATCH on >> DMI_PRODUCT_VERSION with ThinkPads ? That contains the human >> readable model string instead of things like "20UJ", and I guess >> that we want to e.g. apply the s2idle quirk to all "T14s Gen1 AMD" >> ThinkPads. > > Sadly that won't work :( > - The same ID is used for multiple platform names and those can change by geography (for instance China often calls things differently) or if WWAN supported, etc. > - They use the same platform name for Intel and AMD in a few cases (not all). And this match should only be done for the AMD platforms. > > For every platform there are two IDs. In this case the T14s G1 has 20UH and 20UJ. I need to figure out when each is used - I thought only the first one was in released platforms but it seems that's not the case from this patch. I need to understand how/why. > > For models impacted - there are a couple missing from the list that I would expect to see there as they're the same generation: X13 G1 and L15 G2 (and a possible ? against L14/L15 G1). I'm also a bit cautious as the E-series might need to show up here - but I don't know those platforms as well.. > And depending on the two IDs...some of the platforms may need doubling up. Urgh. Ok. Stating the obvious here: Please send a patch adding the necessary extra IDs once you know which ids to add. Regards, Hans
