Hi Mario, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.3-rc4 next-20230330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/PM-Add-a-sysfs-file-to-represent-time-spent-in-hardware-sleep-state/20230331-034714 patch link: https://lore.kernel.org/r/20230330194439.14361-5-mario.limonciello%40amd.com patch subject: [PATCH v5 4/4] platform/x86/intel/pmc: core: Report duration of time in HW sleep state config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20230331/202303311048.UQo0skP2-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/ab8a5cd564c9bd22860612acbd76477f7515ca7b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mario-Limonciello/PM-Add-a-sysfs-file-to-represent-time-spent-in-hardware-sleep-state/20230331-034714 git checkout ab8a5cd564c9bd22860612acbd76477f7515ca7b # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303311048.UQo0skP2-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/platform/x86/intel/pmc/core.c: In function 'pmc_core_is_s0ix_failed': >> drivers/platform/x86/intel/pmc/core.c:1206:9: error: implicit declaration of function 'pm_set_hw_sleep_time' [-Werror=implicit-function-declaration] 1206 | pm_set_hw_sleep_time(s0ix_counter - pmcdev->s0ix_counter); | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/pm_set_hw_sleep_time +1206 drivers/platform/x86/intel/pmc/core.c 1198 1199 static inline bool pmc_core_is_s0ix_failed(struct pmc_dev *pmcdev) 1200 { 1201 u64 s0ix_counter; 1202 1203 if (pmc_core_dev_state_get(pmcdev, &s0ix_counter)) 1204 return false; 1205 > 1206 pm_set_hw_sleep_time(s0ix_counter - pmcdev->s0ix_counter); 1207 1208 if (s0ix_counter == pmcdev->s0ix_counter) 1209 return true; 1210 1211 return false; 1212 } 1213 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests