Hi!
> There are two LED controllers, LEDA indicator LED and LEDB flash LED for
> tps68470. LEDA can be enabled by setting TPS68470_ILEDCTL_ENA. Moreover,
> tps68470 provides four levels of power status for LEDB. If the
> properties called "ti,ledb-current" can be found, the current will be
> set according to the property values. These two LEDs can be controlled
> through the LED class of sysfs (tps68470-leda and tps68470-ledb).
If the LED can have four different currents, should it have 4
brightness levels?
> +++ b/drivers/leds/Kconfig
> @@ -827,6 +827,18 @@ config LEDS_TPS6105X
> It is a single boost converter primarily for white LEDs and
> audio amplifiers.
>
> +config LEDS_TPS68470
> + tristate "LED support for TI TPS68470"
> + depends on LEDS_CLASS
> + depends on INTEL_SKL_INT3472
> + help
> + This driver supports TPS68470 PMIC with LED chip.
> + It provides two LED controllers, with the ability to drive 2
> + indicator LEDs and 2 flash LEDs.
> +
> + To compile this driver as a module, choose M and it will be
> + called leds-tps68470
. at end of line.
> +static const char *tps68470_led_names[] = {
> + [TPS68470_ILED_A] = "tps68470-iled_a",
> + [TPS68470_ILED_B] = "tps68470-iled_b",
No. See Documentation/leds/well-known-leds.txt . We want the LEDs to
be named after their function.
> +static int tps68470_ledb_current_init(struct platform_device *pdev,
> + struct tps68470_device *tps68470)
> +{
> + int ret = 0;
> + unsigned int curr;
> +
> + /* configure LEDB current if the properties can be got */
english?
> + if (!device_property_read_u32(&pdev->dev, "ti,ledb-current", &curr)) {
> + if (curr > CTRLB_16MA) {
We'll need device tree binding documentation, right?
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
