Hi, On 3/9/23 05:01, Dongliang Mu wrote: > The first error handling code in intel_vsec_add_aux misses the > deallocation of intel_vsec_dev->resource. > > Fix this by adding kfree(intel_vsec_dev->resource) in the error handling > code. > > Reviewed-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx> Thank you for your patch, I've applied this patch (as first patch in the series) to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel/vsec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c > index 13decf36c6de..2311c16cb975 100644 > --- a/drivers/platform/x86/intel/vsec.c > +++ b/drivers/platform/x86/intel/vsec.c > @@ -154,6 +154,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, > ret = ida_alloc(intel_vsec_dev->ida, GFP_KERNEL); > mutex_unlock(&vsec_ida_lock); > if (ret < 0) { > + kfree(intel_vsec_dev->resource); > kfree(intel_vsec_dev); > return ret; > }
