On Thu, Mar 16, 2023 at 12:02:04PM -0700, srinivas pandruvada wrote: > Hi Dan, > > On Fri, 2023-03-10 at 14:57 +0300, Dan Carpenter wrote: > > Hello Srinivas Pandruvada, > > > > The patch 33c16dc1a2d1: "platform/x86: ISST: Add IOCTL default > > callback" from Feb 10, 2023, leads to the following Smatch static > > checker warning: > > > > drivers/platform/x86/intel/speed_select_if/isst_if_common.c:6 > > 29 isst_if_def_ioctl() > > info: return a literal instead of 'ret' > > > I use your blog > https://blogs.oracle.com/linux/post/smatch-static-analysis-tool-overview-by-dan-carpenter > > smatch/smatch_scripts/kchecker --spammy > drivers/platform/x86/intel/speed_select_if/isst_if_common.c > CHECK scripts/mod/empty.c > CALL scripts/checksyscalls.sh > DESCEND objtool > INSTALL libsubcmd_headers > CC [M] drivers/platform/x86/intel/speed_select_if/isst_if_common.o > CHECK drivers/platform/x86/intel/speed_select_if/isst_if_common.c > > Also tried with > https://smatch.sourceforge.net/ > > make CHECK="~/path/to/smatch/smatch -p=kernel" C=1 \ > bzImage module > > What is the correct way to run this to get this error? > Sorry, I haven't published this check, yet. I'm still working through some bugs in it. You would think that a check like this would be really simple, but Smatch warns about stuff like: ret = sunxi_nfc_hw_ecc_read_chunks_dma(nand, buf, oob_required, page, nand->ecc.steps); if (ret >= 0) return ret; For some reason in my system Smatch thinks sunxi_nfc_hw_ecc_read_chunks_dma() only returns zero. Which is bogus and I need to fix it before I can publish the check. (That might be a bug from something I did yesterday. My build is very messed up right now. But there are other weirdnesses...) regards, dan carpenter
