Hi,
On 3/13/23 14:02, Hans de Goede wrote:
> The driver auto-loads based on the DMI modaliases and this platform
> modalias is not necessary and broken:
>
> 1. Not necessary since the driver itself creates the platform_device,
> so it is already loaded when the modalias might be used
> 2. From a quick scan of the code it does not create any platform-devices
> called "platform:pcengines-apuv2"
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/pcengines-apuv2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index d063d91db9bc..3aa63b18a2e1 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -291,5 +291,4 @@ MODULE_AUTHOR("Enrico Weigelt, metux IT consult <info@xxxxxxxxx>");
> MODULE_DESCRIPTION("PC Engines APUv2/APUv3 board GPIO/LEDs/keys driver");
> MODULE_LICENSE("GPL");
> MODULE_DEVICE_TABLE(dmi, apu_gpio_dmi_table);
> -MODULE_ALIAS("platform:pcengines-apuv2");
> MODULE_SOFTDEP("pre: platform:" AMD_FCH_GPIO_DRIVER_NAME " platform:leds-gpio platform:gpio_keys_polled");
