On Tue, Mar 07, 2023 at 01:05:40PM +0100, Hans de Goede wrote: > On some MacBooks both the apple_bl and the apple-gmux backlight drivers > may be able to export a /sys/class/backlight device. > > To avoid having 2 backlight devices for one LCD panel until now > the apple-gmux driver has been calling apple_bl_unregister() to move > the apple_bl backlight device out of the way when it loads. > > Similar problems exist on other x86 laptops and all backlight drivers > which may be used on x86 laptops have moved to using > acpi_video_get_backlight_type() to determine whether they should load > or not. > > Switch apple_bl to this model too, so that it is consistent with all > the other x86 backlight drivers. > [snip] > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> but... > --- > A note to the backlight class / subsystem maintainers, this change > applies on top of a similar patch for drivers/platform/x86/apple-gmux.c > which makes that driver use acpi_video_get_backlight_type(). See: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > I believe it is easiest to also merge this patch through > the platform-drivers-x86 tree, may I please have your Ack for this ? > --- ... please don't treat above as an ack. Lee Jones will hopefully be along shortly to discuss that! Daniel.
